Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistent rq status naming and handling #6913

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

AndrewChubatiuk
Copy link
Contributor

What type of PR is this?

  • support more RQ statuses (STOPPED, CANCELED, DEFERRED, etc)

  • consistent status naming

  • replaced deprecated job result handling methods

  • Refactor

  • Feature

  • Bug Fix

  • New Query Runner (Data Source)

  • New Alert Destination

  • Other

Description

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

@justinclift
Copy link
Member

Looks like it needs a bit more attention in order to pass CI. 😉

@AndrewChubatiuk
Copy link
Contributor Author

Looks like it needs a bit more attention in order to pass CI. 😉

just had to update a test

@justinclift
Copy link
Member

@gaecoli @wlach Eyeballing this, it seems sensible. You're both better at Python than me though, so would either of you be ok to take a quick look over this to make sure there's nothing I missed? 😄

Copy link
Member

@gaecoli gaecoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@justinclift justinclift merged commit 5ac5d86 into getredash:master Apr 24, 2024
11 checks passed
@AndrewChubatiuk AndrewChubatiuk deleted the consistent-rq-statuses branch April 24, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants